Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-hot-toast animation for indicating success and failure in the client side #38

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

batunpc
Copy link
Collaborator

@batunpc batunpc commented Dec 10, 2022

Fixes #37

Warning: Before this PR to be merged and reviewed, please first read through the other PR I have raised at #35. Since this changes also includes the changes from previous PR

I have used react-hot-toast module to add spinner animation.

A fail on uploading a photo will look like

CleanShot 2022-12-10 at 02 31 22@2x

A successful attempt of uploading photo will look like

CleanShot 2022-12-10 at 02 31 02@2x

@batunpc batunpc self-assigned this Dec 10, 2022
@batunpc batunpc changed the title react-hot-toast animation (spinner) for indicating success and failure in the client side react-hot-toast animation for indicating success and failure in the client side Dec 11, 2022
Copy link
Collaborator

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this is rebased on the work from the other PR, this is good to go I think. Nice fix.

@batunpc
Copy link
Collaborator Author

batunpc commented Dec 16, 2022

Thank you, just updated the #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI state changes for sufficient representation of success & error
3 participants